Allow importing files with MIME type "application/octet-stream" #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes Android reports the MIME type as "application/octet-stream" even if the file has a .json extension (specifically, on Android 8 and 9 for backups exported outside the Download folder). Previously, such files could not be selected in the file picker when importing. As a workaround, allow files with that MIME type. Fixes FossifyOrg#88.
tom93
force-pushed
the
fix-import-binary-mime-type
branch
from
79c9909
to
b18e8aa
Compare
FossifyOrg/Notes#34 seems like a similar issue. |
naveensingh
reviewed
Nov 29, 2024
| @@ -27,7 +27,7 @@ class SettingsActivity : SimpleActivity() { | |||
| private var blockedNumbersAtPause = -1 | |||
| private var recycleBinMessages = 0 | |||
| private val messagesFileType = "application/json" | |||
| private val messageImportFileTypes = listOf("application/json", "application/xml", "text/xml") | |||
| private val messageImportFileTypes = listOf("application/json", "application/xml", "text/xml", "application/octet-stream") | |||
There was a problem hiding this comment.
@tom93 why not do this at runtime for Android 8/9 only? That way, the behavior won't change on newer versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes Android reports the MIME type as "application/octet-stream" even if the file has a .json extension (specifically, on Android 8 and 9 for backups exported outside the Download folder). Previously, such files could not be selected in the file picker when importing.
As a workaround, allow files with that MIME type.
@devs: Should I also port this fix to the other apps that have a JSON import feature?
What is it?
Before/After Screenshots/Screen Record
No response
Fixes the following issue(s)
Acknowledgement