Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The options in 'Lock screen notification visibility' are applied also when the screen is unlocked #323

Open
7 tasks done
antodc opened this issue Feb 14, 2025 · 14 comments
Open
7 tasks done
Labels
bug Something is not working

Comments

@antodc
Copy link
Contributor

antodc commented Feb 14, 2025

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.3.1

Affected Android/Custom ROM version

Android 11

Affected device model

Oscal C60

How did you install the app?

GitHub releases

Steps to reproduce the bug

In settings there are three options for 'Lock screen notification visibility' ('Sender and message', 'Sender only', and 'Nothing'). However, those options are applied also when the screen is unlocked. So, if for instance I choose 'Nothing', I do not get any info about an incoming message also when the screen is not locked.

Expected behavior

The options in 'Lock screen notification visibility' are applied only when the screen is locked

Actual behavior

The options in 'Lock screen notification visibility' are always applied, independently on whether the screen is locked or not

Screenshots/Screen recordings

No response

Additional information

I think that it would be usefull to have a similar set of options also for the case in which the screen is not locked, i.e. to have 'Unlock screen notification visibility' in settings.
I know that I should probably make a feature request once this issue has been addressed, but maybe it is simpler (or not so difficult) to implement both things toghether.

@antodc antodc added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Feb 14, 2025
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 14, 2025
@Candlemass
Copy link

My device is also on a variant of Android 11 and when this "Lock screen notification visibility" option is set to either "sender only" or "sender and message" no text notification information is displayed on the lock screen or the pull down menu while the device is locked. It only enables text notification previews while the device is unlocked from the top pull down menu. Although I'm not sure if this is due to other strict settings on my device to restrict all notifications being displayed while the device is locked due to privacy/security reasons.

Either way, the correct label for this option as mentioned in my other issue report is "notification previews" since it has nothing to do with the lock screen.

Until the dev explicitly mentions what the purpose of this setting is I don't know if it's incorrectly labelled or an actual bug since as the OP states one would logically assume this behavior is different and/or a separate option.

@antodc
Copy link
Contributor Author

antodc commented Feb 14, 2025

@Candlemass What do you have in Settings-> Display-> Lock Screen-> Notifications on lock screen?

@Candlemass
Copy link

@antodc

"Don't show notifications at all"

@antodc
Copy link
Contributor Author

antodc commented Feb 14, 2025

So, the system does what you asked it to do and that is why you do not see any notification when the screen is locked.

@Aga-C
Copy link
Member

Aga-C commented Feb 14, 2025

The options in 'Lock screen notification visibility' are always applied, independently on whether the screen is locked or not

@antodc That's not true. Showing sender only isn't working at all, and there's already a bug report for it: #44. Please modify your bug report to be only about Nothing option.

@Aga-C Aga-C added waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Feb 14, 2025
@antodc
Copy link
Contributor Author

antodc commented Feb 15, 2025

@Aga-C What do you mean? In my case, if I set ‘Sender only’ I see only the sender, both in locked and unlocked screen. Then, if I scroll down the notification I can see the text, both in locked and unlocked screen. So, the behaviour is the same in both cases, while it should not. This is what this bug report says. Then, if the behaviour itself is not what is expected, as I argue from #44, it is a different matter.

@Aga-C Aga-C removed waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Feb 15, 2025
@Aga-C
Copy link
Member

Aga-C commented Feb 15, 2025

I've tested in more thoroughly and in fact it shows only sender on the unlocked screen. Sorry for the confusion.

@Candlemass
Copy link

@Aga-C

So was the intended purpose of this setting only to show sms notifications on the lock screen or system wide?

You still have not made a statement on how you invisioned this setting functioning.

@naveensingh
Copy link
Member

@Candlemass

These apps were originally designed and created by Tibor Kaputa and he's not here so we can only guess based on the label.

The preference should only affect notifications on the lock screen and anything else is a bug.

You still have not made a statement on how you invisioned this setting functioning.

Aga-C is only helping out here, nobody is "responsible" for anything.

@antodc
Copy link
Contributor Author

antodc commented Feb 16, 2025

The preference should only affect notifications on the lock screen and anything else is a bug.

Just for the records, @Aga-C already gave the same answer a few days ago here #321 (comment) .

Perhaps @Candlemass missed it.

That answer was the reason why I opened this bug report.

@Candlemass
Copy link

Candlemass commented Feb 17, 2025

@Candlemass

These apps were originally designed and created by Tibor Kaputa and he's not here so we can only guess based on the label.

The preference should only affect notifications on the lock screen and anything else is a bug.

You still have not made a statement on how you invisioned this setting functioning.

Aga-C is only helping out here, nobody is "responsible" for anything.

Don't put words in my mouth.

Not once did I mention that anyone was "responsible" for anything but unless the maintainers of this current project explicitly state how a setting is supposed to function then logic would dictate it's nearly impossible to figure out if it's a bug or just poorly worded.

@Candlemass
Copy link

Candlemass commented Feb 17, 2025

The preference should only affect notifications on the lock screen and anything else is a bug.

Just for the records, @Aga-C already gave the same answer a few days ago here #321 (comment) .

Perhaps @Candlemass missed it.

That answer was the reason why I opened this bug report.

He stated in the last post of that report that it "should" work when the screen is unlocked which would indicate the setting is incorrectly named and a bug?

And now @naveensingh mentions the opposite in this report....

Are you following along?

@naveensingh
Copy link
Member

naveensingh commented Feb 17, 2025

it's nearly impossible to figure out if it's a bug or just poorly worded.

Generally, any behavior that falls outside the scope of a setting is a 'bug'. In some cases, it is poorly worded and the setting "intentionally" affects more than what one would initially imagine but that's not the case here.

He stated in the last post of that report that it "should" work when the screen is unlocked which would indicate the setting is incorrectly named and a bug?
And now @naveensingh mentions the opposite in this report....

What Aga-C meant in her follow-up comment was that the preference "should" work as defined by the label, not that it "should" hide the contents after the device is UNLOCKED.

There is no contradiction here:

  • The preference is labelled "Lock screen notification visibility"
  • Aga-C said "It should work as defined by the label"
  • I said "The preference should only affect notifications on the lock screen and anything else is a bug"

I believe the confusion here is due to gaps in communication, perhaps because not all of us are native English speakers. I hope it is clear now that this is indeed a bug, not intended behavior.

@Candlemass
Copy link

Candlemass commented Feb 18, 2025

it's nearly impossible to figure out if it's a bug or just poorly worded.

Generally, any behavior that falls outside the scope of a setting is a 'bug'. In some cases, it is poorly worded and the setting "intentionally" affects more than what one would initially imagine but that's not the case here.

He stated in the last post of that report that it "should" work when the screen is unlocked which would indicate the setting is incorrectly named and a bug?
And now @naveensingh mentions the opposite in this report....

What Aga-C meant in her follow-up comment was that the preference "should" work as defined by the label, not that it "should" hide the contents after the device is UNLOCKED.

There is no contradiction here:

  • The preference is labelled "Lock screen notification visibility"
  • Aga-C said "It should work as defined by the label"
  • I said "The preference should only affect notifications on the lock screen and anything else is a bug"

I believe the confusion here is due to gaps in communication, perhaps because not all of us are native English speakers. I hope it is clear now that this is indeed a bug, not intended behavior.

Then that means my initial thread requesting this feature is valid since there is no native option to display notification previews from the top pull down menu once the device is unlocked since the current behavior is allegedly a bug.

Option to enable notification preview from pull down menu #321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants