Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic shortcuts for speed dial entries #246

Closed
wants to merge 1 commit into from

Conversation

Grafcube
Copy link

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Description of the changes in your PR

  • photoUri is added to the SpeedDial class for the shortcut's icon.
  • It uses ACTION_DIAL instead of ACTION_CALL if calling permission is denied.

Acknowledgement

@naveensingh
Copy link
Member

Thanks for your contribution!

I'll be closing this because favorite contacts are more suited as shortcuts than speed dial entries. Also, PRs have a better chance of being accepted if they have a dedicated issue/discussion as mentioned in the contribution guidelines.

If you try fixing a bug or adding a new feature, make sure that it is already reported at the given repository and the report is open without label needs triage. If the given issue is closed or still has needs triage label, your pull request will likely be rejected. The only exceptions are critical bugs that we weren't able to classify yet.

Please feel free to raise another PR that works with favorite contacts and it might get merged before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants