Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-paste error in the main CMakeLists.txt #1628

Closed
Dizzy55 opened this issue Nov 23, 2024 · 3 comments
Closed

Copy-paste error in the main CMakeLists.txt #1628

Dizzy55 opened this issue Nov 23, 2024 · 3 comments

Comments

@Dizzy55
Copy link

Dizzy55 commented Nov 23, 2024

Hi,

There are two if with the same condition. Looks like a copy error

if(OSMSCOUT_BUILD_MAP_QT)
  if(OSMSCOUT_BUILD_MAP_QT)
    add_subdirectory(libosmscout-map-qt)
  endif()
endif()

This line

@Karry
Copy link
Collaborator

Karry commented Nov 25, 2024

There was missing check for library dependency: #1630 . Thank you for report.

@Dizzy55
Copy link
Author

Dizzy55 commented Nov 29, 2024

The fix looks good))) Can I close the issue?

@Framstag
Copy link
Owner

I'll close for you, thanks for creating the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants