Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use property decorator for model & tokenizer objects #98

Open
3 of 5 tasks
LexABzH opened this issue Dec 19, 2022 · 1 comment
Open
3 of 5 tasks

Use property decorator for model & tokenizer objects #98

LexABzH opened this issue Dec 19, 2022 · 1 comment
Labels
3 - Quality of Life Not a priority enhancement New feature or request NLP Issue related to the NLP template NUM Issue related to the NUM template VISION Issue related to the VISION template

Comments

@LexABzH
Copy link
Collaborator

LexABzH commented Dec 19, 2022

Problem

We have many attributes that can be properties, such as model & tokenizer objects.
Hence we could get rid of the _get_model & _get_tokenizer functions.

Concerned template

  • NLP template
  • NUM template
  • VISION template
  • API template
  • How templates are generated - Jinja

Solution

Set model & tokenizer objects as properties.

Additional context

Tests will need changes
@LexABzH LexABzH added enhancement New feature or request NLP Issue related to the NLP template NUM Issue related to the NUM template VISION Issue related to the VISION template 3 - Quality of Life Not a priority labels Dec 19, 2022
@LexABzH
Copy link
Collaborator Author

LexABzH commented Dec 22, 2022

Maybe rework tokenizer for Keras models (add a _get_tokenizer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - Quality of Life Not a priority enhancement New feature or request NLP Issue related to the NLP template NUM Issue related to the NUM template VISION Issue related to the VISION template
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LexABzH