Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use test dataset as validation dataset? #8

Open
liubingai opened this issue Jun 18, 2018 · 1 comment
Open

use test dataset as validation dataset? #8

liubingai opened this issue Jun 18, 2018 · 1 comment

Comments

@liubingai
Copy link

Hello Frank, @FrankWork

I think you have implemented the model well. However, it seems you have made a mistake because you use test dataset as the validation dataset (which is forbidden absolutely in ML). So, I think the performance you have showed in log files is not exact.

Maybe I have misunderstood your code. Expecting your reply.

@FrankWork
Copy link
Owner

you are right. I used test dataset as the validation set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants