Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the documentation on Raviart-Thomas element #45

Open
frbo77 opened this issue Feb 23, 2024 · 0 comments
Open

Correct the documentation on Raviart-Thomas element #45

frbo77 opened this issue Feb 23, 2024 · 0 comments

Comments

@frbo77
Copy link

frbo77 commented Feb 23, 2024

The documentation on Raviart-Thomas element section 3.3.10 has some mistakes/incompleteness

-- The formula giving fh=f_h(x,y) has some typo: the last term \phi_{i_lj_l} should be replaced by \phi_{i_l}^k

-- The comments explain the orientation of the edges: from small to large indices of the vertices.
"for example we can" should be replaced by just "we"
Once the edge is oriented, we must give the orientation of the normal n_e, which is not said.
I propose to insert "Then the normal $n_e$ is oriented so as to point to the right with respect to the direction of the edge". This is coherent with the boundary convention of FreeFem : the domain is on the left, and here it means that the normal will be external on the boundary of the domain (if the boundary vertices are labeled increasingly in counterclock sense).
This choice of orientation corresponds to what I observe when I use RT0 in my FreeFem codes, with regards to the fact that according to the definition of the dof, one must have phi_i^k(m_i)\cdot n_i > 0.
If you take in the code the basis function and you take the scalar product with the normal, you see according to the sign of the result and the indices of the two vertices that the above orientation is the one that is set in FreeFem. Fig 3.35 illustrates the case i_c<i_a<i_b.
In consequence we see that the formulas for the basis functions phi_i^k in the documentation have a WRONG SIGN: there should be a minus in front of each of the three formulas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant