Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging macros are not namespaced #390

Open
themightyoarfish opened this issue May 16, 2022 · 2 comments
Open

Logging macros are not namespaced #390

themightyoarfish opened this issue May 16, 2022 · 2 comments

Comments

@themightyoarfish
Copy link

#define LOG_TRACE(__logger__, ...) { if (__logger__ && __logger__->should_log(spdlog::level::trace)) { __logger__->trace(__VA_ARGS__); }}

As this is a library, it would be appropriate to namespace these global macros, e.g. LOG_INFO -> FREEOPCUA_LOG_INFO to avoid conflicting with client code. We have a codebase that does internal logging and now needs to hack around this. Probably we should rename also, but for a library even more important.

@guojing555
Copy link

guojing555 commented May 16, 2022 via email

@themightyoarfish
Copy link
Author

Is this library maintained actually? It kinda seems dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants