You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#defineLOG_TRACE(__logger__, ...) { if (__logger__ && __logger__->should_log(spdlog::level::trace)) { __logger__->trace(__VA_ARGS__); }}
As this is a library, it would be appropriate to namespace these global macros, e.g. LOG_INFO -> FREEOPCUA_LOG_INFO to avoid conflicting with client code. We have a codebase that does internal logging and now needs to hack around this. Probably we should rename also, but for a library even more important.
The text was updated successfully, but these errors were encountered:
freeopcua/include/opc/common/logger.h
Line 29 in bd13aee
As this is a library, it would be appropriate to namespace these global macros, e.g.
LOG_INFO
->FREEOPCUA_LOG_INFO
to avoid conflicting with client code. We have a codebase that does internal logging and now needs to hack around this. Probably we should rename also, but for a library even more important.The text was updated successfully, but these errors were encountered: