[support presigned URL] support http request without HTTP_USER_AGENT_FIELD #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GENT_FIELD needed for presigned URL
|
/bot run formatting |
|
Hello @giuspen, Thank you for raising the PR! We will be looking further into this issue as soon as we can, thank you for your patience!” |
tony-josi-aws
force-pushed
the
GP_HTTP_REQUEST_NO_USER_AGENT_FLAG
branch
from
3bf240d
to
3dcb439
Compare
archigup
reviewed
Oct 13, 2023
archigup
previously approved these changes
Oct 19, 2023
archigup
approved these changes
Oct 24, 2023
AniruddhaKanhere
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Thank you for these changes and the tests @giuspen.
The changes look good to me.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support http request without HTTP_USER_AGENT_FIELD
Description
As discussed in aws/aws-iot-device-sdk-embedded-C#1887 I have made changes to an existing demo http_demo_s3_download to generate a presigned URL instead of directly downloading the file.
I'm planning, if the changes to the submodules are accepted, to then generate a new demo called http_demo_s3_presigned_url or something like that.
You can see/test my work at https://github.com/giuspen/aws-iot-device-sdk-embedded-C/tree/GP_http_demo_s3_download_test_signature (only generate presigned URL) or https://github.com/giuspen/aws-iot-device-sdk-embedded-C/tree/GP_http_demo_s3_download_test_signature2 (download and also generate presigned URL)
Test Steps
Exact same requirements of original demo http_demo_s3_download
Checklist:
Related Issue
aws/aws-iot-device-sdk-embedded-C#1887
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.