-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MISRA fixes #153
MISRA fixes #153
Conversation
/bot run formatting |
/bot run formatting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear why we need to change this. There must be a better way to satisfy the customer's MISRA checker.
/bot run formatting |
MISRA C 2012 rule 20.12 deviation doesn't seem to be fixed when |
Description
MISRA violations identified through the use of Coverity and here
Fixes to violations of MISRA rule 10.3 and rule 20.12
MISRA rule 10.3 violations: assigning expression of essentially unsigned type to an object with essentially signed type. (int32_t value = 0U;) and assignment of int8_t to a char (char_ c = { 0 }; and char_ n = { 0 };)
MISRA rule 20.12 violation: assert( isOpenBracket_( mode ) ); -> Here, macro parameter isOpenBracket_ (which is also macro) is itself subject for further macro replacement (#expr), supplied as expr parameter.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.