Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not icon and some eeror in console(at video.js 8.0.3 8.0.4) #55

Open
R8KwEwN2hvrhY opened this issue Feb 3, 2023 · 13 comments
Open

not icon and some eeror in console(at video.js 8.0.3 8.0.4) #55

R8KwEwN2hvrhY opened this issue Feb 3, 2023 · 13 comments

Comments

@R8KwEwN2hvrhY
Copy link

not icon and some eeror in console
屏幕截图 2023-02-03 170502

@ChunkyProgrammer
Copy link
Member

What error do you get when you don't use the min file?

@R8KwEwN2hvrhY
Copy link
Author

at video.js8 extends has been discard,but i saw the videojs-http-source-selector need that .i don't get it have
difference between in min_file or all_file

@R8KwEwN2hvrhY
Copy link
Author

that is not use minfile eeor.
2222

@R8KwEwN2hvrhY
Copy link
Author

new image,video.js not min
333

1 similar comment
@R8KwEwN2hvrhY
Copy link
Author

new image,video.js not min
333

@ChunkyProgrammer
Copy link
Member

Could you try the latest commit?

@R8KwEwN2hvrhY
Copy link
Author

R8KwEwN2hvrhY commented Feb 8, 2023

Could you try the latest commit?

at first open can't saw it,but second just like that
屏幕截图 2023-02-08 120414

@R8KwEwN2hvrhY
Copy link
Author

first open can't saw it maybe network too slow,i have question the css file is necessary?and thank your work~

@R8KwEwN2hvrhY
Copy link
Author

i hope the label at 'auto' display like youtube can see the current quality,jus like 'auto 720p'

@josephsellers
Copy link

Hi @friendtasy,

I believe the CSS is necessary to display the little cog icon. I had to tweak the CSS because it styled other plugin menu entries as well. I made it more specific. I am not great with CSS or I would submit this as a PR. However, it might work for you as well as I can see in the screenshot above that you have two cogs showing as well so might have the same issue.

.video-js.vjs-http-source-selector {
  display:block
}

div.vjs-http-source-selector > button:nth-child(1) > span:nth-child(1)::before {
  font-family:VideoJS;
  font-weight:normal;
  font-style:normal;
  content:"\f110"
}

@ChunkyProgrammer
Copy link
Member

ChunkyProgrammer commented Feb 16, 2023

@josephsellers Could you try the latest commit? I updated the css

@R8KwEwN2hvrhY
Copy link
Author

i try it,i don't found any question.
屏幕截图 2023-02-18 155246

but the question no change
#60

@R8KwEwN2hvrhY
Copy link
Author

two cogs because one is speed change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants