Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of Entry information pages #564

Open
richardofsussex opened this issue Mar 12, 2024 · 25 comments
Open

Consistency of Entry information pages #564

richardofsussex opened this issue Mar 12, 2024 · 25 comments
Assignees
Labels
Entry information page MVP Minimum Viable Product (Requirement for launch) ready for deployment ready to be rolled out to live.

Comments

@richardofsussex
Copy link

richardofsussex commented Mar 12, 2024

The standard Entry information page, as displayed from search results:

image

does not look the same as, or contain the same information as, the Entry information page which is displayed when you enter the 'hash URL' (e.g. http://localhost:3000/entry-information/9Llytp0ZnMt2i7KwdA5uZA/hash):

image

There may be other variants of the Entry information page elsewhere in the BMD2 ecosystem: @Vino-S can advise. I think they should all have the same design and information content, unless there are clear reasons for them to vary. Ideally they should (for ease of maintenance in future) all be generated from the same code.

@richardofsussex
Copy link
Author

It looks as though there are two variants within BestGuessHash: bmd1_show.html.erb and show.html.erb. as well as the 'default' page which is defined in BestGuess; also show.html.erb.

@richardofsussex
Copy link
Author

A single saved record has a similar Entry information display to the standard search results one, but lacks the More information row:

image

@KristinaGadzhieva KristinaGadzhieva added the MVP Minimum Viable Product (Requirement for launch) label Apr 30, 2024
@KristinaGadzhieva
Copy link
Collaborator

I suggest checking whether the page follows the wireframe design. For example, buttons 'Back to results' and 'Generate citation' should be aligned to the left side of the page. The fields in the table need to be done according to the wireframe. (We have separate stories for this)

@nurifreembd
Copy link
Collaborator

consider aligning text left if it helps with the presentation of the records to the Researchers.

@nurifreembd
Copy link
Collaborator

Consider updating the envelope image within the postem row to read 'Add a postem'.

@KristinaGadzhieva
Copy link
Collaborator

Nuri, thank you for your comments. I have added a point about the envelope to story #595.
I can also add the text alignment, @richardofsussex @DeniseColbert, what do you think?

@KristinaGadzhieva
Copy link
Collaborator

@nurifreembd Nuri, I'm sorry, I forgot that we have changed the Postems view and have a different implementation on test 3. On test 3 there is 'Postems', and when you click on it, the option 'Add a postem' appears. Could please have a look at test 3?

@nurifreembd
Copy link
Collaborator

nurifreembd commented Nov 21, 2024 via email

@KristinaGadzhieva
Copy link
Collaborator

@nurifreembd I've checked Postems on Beta, works well

@KristinaGadzhieva
Copy link
Collaborator

KristinaGadzhieva commented Dec 10, 2024

Suggestions for discussion:

  1. Update a link to the Help section about quarters, districts, and how to find the partner in a marriage.
  2. Separate the two links to Help page more clearly. The second one starts with 'Need help?'.
  3. Shorten sentences related to Help (to make them easier and quicker to read)
  4. Move 'Previous Result', 'Next result' below the table or at the bottom of the page
  5. Allign the links 'Back to results', 'Genarate citation', 'Print' to the left (to make them consistent with the Results page)

@richardofsussex @DeniseColbert @nurifreembd please, let me know what you think.

@nurifreembd
Copy link
Collaborator

@KristinaGadzhieva Retested too and it works. Thanks

@nurifreembd
Copy link
Collaborator

nurifreembd commented Dec 10, 2024 via email

@richardofsussex
Copy link
Author

richardofsussex commented Dec 11, 2024

A general observation: this is not what this story was originally about. It was talking about Entry information pages being displayed in different contexts (e.g. as a saved record), and the fact that these different manifestations of the Entry information page were not identical. It now appears to be a 'fix list' for the principal Entry information page.

@richardofsussex
Copy link
Author

Having said that ...

1-3. Yes we have effectively the same text about help, twice, with different links in each, neither of which is correct.
4. This has been actioned in beta, but the 'back' and 'forward' links should be on the same 'line'. At present 'forward' is below 'back'.
5. Agreed

@KristinaGadzhieva
Copy link
Collaborator

Right, Richard. However, we have similar stories related to inconsistencies on other pages. Let's keep this story active as part of the fix list.

@KristinaGadzhieva
Copy link
Collaborator

1-3 @richardofsussex Richard, could you please help with text adjustments related to the help?
4 - On Beta navigation buttons are also 'between' text. They are not quite visible. Could we consider moving them under the table?
5- Agreed 'Allign the links 'Back to results', 'Genarate citation', 'Print' to the left (to make them consistent with the Results page) ' @Vino-S could you please make it on test 3 ?

@richardofsussex
Copy link
Author

richardofsussex commented Dec 13, 2024

1-3 Yes, I can update that text and remove the duplication. I'll need to check where the link should be pointing.
Note that the current help doesn't say anything about Districts, so the link text is misleading.

@richardofsussex
Copy link
Author

Further suggestions:
6. Mixed case for Record type ("Death" not "DEATH")
7. Work out whether it's Age at Death or Date of birth and output the appropriate heading.

@richardofsussex
Copy link
Author

@Vino-S please push fb_564_rbl to test3. I have attempted to deal with all the issues above (including 5).

@Vino-S
Copy link
Collaborator

Vino-S commented Dec 16, 2024

@richardofsussex test3 updated

@richardofsussex
Copy link
Author

Thanks @Vino-S. 4 hasn't quite worked - if there is a query about the record, it appears above the previous/next record links. I'll fix and re-push my branch.

@richardofsussex
Copy link
Author

fb_564_rbl now updated and pushed to GitHub.

@Vino-S
Copy link
Collaborator

Vino-S commented Dec 17, 2024

Hi @richardofsussex , test3 updated

@KristinaGadzhieva
Copy link
Collaborator

Thank you.
1-3 Let's get back to them after completing the Help page.
4, 5 - Now is fine.
6, 7 - I agree.

@KristinaGadzhieva
Copy link
Collaborator

4 -7 Ready for deployment

@KristinaGadzhieva KristinaGadzhieva added the ready for deployment ready to be rolled out to live. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entry information page MVP Minimum Viable Product (Requirement for launch) ready for deployment ready to be rolled out to live.
Projects
None yet
Development

No branches or pull requests

4 participants