-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra information (mother’s maiden name/age at death/spouse surname etc) on the Results page #582
Comments
This is now on test3 |
Where are we at with this issue? What needs to be done/fixed? |
I don't see the changes related to this story on test 3. There is no information in the column (MMN, AAD, SS). |
In the description of this story: To put extra information (mother’s maiden name/age at death/spouse surname etc) in a separate table column on the Results page. |
Right. I was looking for Josephine Smith, from 1837 to 1905 |
@richardofsussex |
@richardofsussex I've listened to the table on a screen reader. It took me 9 or 10 presses (I lost count) to get through the info in the second column (but perhaps I'm not using the best method to hear the contents of that cell?). I do not think the description list is the best way of marking up the information in that column: for a start there are lots of terms, The Again, there is no help with understanding the meaning of the heading of the third column. |
What HTML markup would you recommend to achieve the layout we currently see? Or would you advise going to something more like the FreeREG and FreeCEN results tables, with a column for each item of information? The As regards 'MMN/AAD/SS', we are obviously trying to avoid an enormous column heading. We could put 'Mother's maiden name/Age at death/Spouse's surname' which would remove your problem. Is there another technique we can use with HTML that would allow us to keep the abbreviated heading but would be screen-reader-friendly? |
@richardofsussex It is not my problem. It’s an issue for most users (unless they are mind readers). Not just for screen reader users either. For the latter group, an explanation in the |
To discuss with the Steering group |
Results table layout changed as requested and explanations added/updated: see |
Maybe I'm jumping the gun, but I'm getting this for the caption of a 4-column table: I do see "Mother's maiden name" for the heading for column 3 where I searched for births; "Age at death" for deaths; "AAD/SS" for marriages and deaths, with no explanation of the abbreviations. |
You are indeed jumping the gun - @Vino-S has not yet had chance to move my changes to beta. |
Have a look now ... |
Thanks! I can see the changes now … doh! I'm thinking that vol # and page # are superfluous in the results table and would be better saved for details page (as unlikely to affect a user's initial judgement of a result). Also The links group (nice one) would be better marked up in a {I am done in so will stop for now … thoughts on |
Some more thoughts: The interesting info that there are however many results is lurking in an anonymous I'm not yet sure how to deal with the level 4 heading being before the level 1 heading. The obvious thing to do is to put the level 1 heading ahead of the Search criteria. And then make the hidden level 4 heading a level 2. Maybe make the search criteria box an aside that is labelled by the level 2 heading. Thoughts on |
Back to the The setup seems quite complicated in that, in order to sort or apply a filter, a screen reader user is required to navigate from the table to the form and then back to the table, each time going via the rotor, probably. Altogether, quite a lot of faff. And most of the faff is understandable — we offer to sort on several criteria that do not have their own column. However, it does seem unfair on SR users. And it makes for a long caption, explaining not only the structure of the table but also how to sort or filter the results. The obvious alternative would be to put each of the sortable items in their own column and put buttons in the table header cells to do the sorting. This could make problems for mobile-size screens. I seem to remember that REG solved this by using a description list on mobile screens (and using device-sniffing to decide whether to supply a table or a Some experimentation will be needed, whatever is decided. There is more information on: |
The name links need to look like links - in fact all the links lack an underscore. I would question whether there is any practical value in the type of event filter, given that users can easily adjust this by updating their search and re-running it (or by asking for what they want in the first place!). |
Waiting for this to be added to Test 2 so we can consider this 'new' layout |
The new layout is in test2 |
Thanks Vino. Is everyone happy with this new layout? |
Responsiveness of the search results table is a separate issue (albeit one which has been surfaced by the table being wider). I have created a new issue #593 to address it. |
Ready for testing on Beta |
@KristinaGadzhieva The Extra column will appear for all record types. |
@Vino-S Right, sorry, it didn't notice that I accidentally selected one record type. It works, thank you. I'm closing the story. |
To put extra information (mother’s maiden name/age at death/spouse surname etc) in a separate table column on the Results page.
The text was updated successfully, but these errors were encountered: