Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results page: show unknown if DOB/age blank #604

Open
nurifreembd opened this issue Nov 26, 2024 · 31 comments
Open

Results page: show unknown if DOB/age blank #604

nurifreembd opened this issue Nov 26, 2024 · 31 comments
Assignees
Labels
MVP Minimum Viable Product (Requirement for launch) Results page

Comments

@nurifreembd
Copy link
Collaborator

Results page: Age at Death/Date of Birth - currently shows blank cell. Suggestion is to show 'unknown' if no record of DOB/age.

@AlOneill
Copy link
Collaborator

I suggest that 'not recorded' (or similar) would be more accurate and honest than 'unknown' in most instances.

@nurifreembd
Copy link
Collaborator Author

sure, better then leaving it blank.

@KristinaGadzhieva
Copy link
Collaborator

Can we show 'Not applicable' for DOB, as well as for Mother's Maiden Name, Spouse's Surname? Blank cells in the table look unclear, either there is no data, or there is an error, or the table is not completed. @nurifreembd @AlOneill @richardofsussex

@KristinaGadzhieva KristinaGadzhieva added the MVP Minimum Viable Product (Requirement for launch) label Dec 3, 2024
@AlOneill
Copy link
Collaborator

AlOneill commented Dec 4, 2024

'Applicable' requires a higher reading age (in English) than 'recorded'. We should opt for the simplest way to express that the data was not collected at that time. 'Unknown' is bad because it is not true. Blank is bad because it looks as if something has gone wrong.

@nurifreembd
Copy link
Collaborator Author

nurifreembd commented Dec 4, 2024 via email

@KristinaGadzhieva
Copy link
Collaborator

How about 'No data' ? It seems quite simple and clear.

@nurifreembd
Copy link
Collaborator Author

nurifreembd commented Dec 4, 2024 via email

@AlOneill
Copy link
Collaborator

AlOneill commented Dec 4, 2024

@KristinaGadzhieva Yes! Perfect.

@AlOneill
Copy link
Collaborator

AlOneill commented Dec 4, 2024

@nurifreebmd Too long and complicated. Also, very likely to be missed by a screen reader user who goes straight to the table.

@richardofsussex
Copy link

@AlOneill presumably your comment relates to Nuri's suggestion? I was going to suggest 'No data' myself.

@AlOneill
Copy link
Collaborator

AlOneill commented Dec 4, 2024

To clarify, I think 'No data' is (almost) perfect. (Almost because a user might ask, "and why not?" — my literal brain is on overdrive!! )

@richardofsussex
Copy link

richardofsussex commented Dec 4, 2024

I think that can be addressed in the help, where we can explain that the GRO have changed the information they record in the index over the years, and we can only offer the data actually recorded for any given event.

@KristinaGadzhieva
Copy link
Collaborator

Sure, we can provide clarification on the Help page. So I think we all agreed on 'No data'.

@nurifreembd
Copy link
Collaborator Author

nurifreembd commented Dec 4, 2024 via email

@richardofsussex
Copy link

OK, now implemented:
image
As you will see, I have also changed the case of the event type and made it singular. @Vino-S the changes are in fb_604_rbl, if you could please push them to test3.

@KristinaGadzhieva
Copy link
Collaborator

Thank you very much everyone!
@richardofsussex Richard, there are several empty cells in the screenshot. They don't have data either?

@richardofsussex
Copy link

Those are cells which are not relevant to that particular event type, and so can never contain data (e.g. Mother's Maiden Name and Age at Death for a marriage record). We could put 'No data' in those as well, but personally I think it would make the listing look cluttered.

@KristinaGadzhieva
Copy link
Collaborator

Yes, it would be cluttered. We can leave as it is for now and wait for user feedback.

@nurifreembd
Copy link
Collaborator Author

nurifreembd commented Dec 5, 2024 via email

@KristinaGadzhieva
Copy link
Collaborator

We can show ND in each cell and make a note below the table for users explaining the meaning.

@richardofsussex
Copy link

Add dashes in currently blank cells.

@KristinaGadzhieva
Copy link
Collaborator

@AlOneill do you agree with the proposed approach:

  • to display a dash in cells which are not relevant to a particular event type
  • to show 'no data' in cells for which the data was not collected
    and add a note below the table with explanation for users ?

@richardofsussex
Copy link

Implemented:
image
@Vino-S please push to test3.

@nurifreembd
Copy link
Collaborator Author

nurifreembd commented Dec 10, 2024 via email

@richardofsussex
Copy link

Now on test3 - thanks @Vino-S. (BTW, I also changed e.g. 'BIRTHS' to 'Birth' as discussed. Bonus!)

@KristinaGadzhieva
Copy link
Collaborator

I think it would be worth adding an explanation of the difference between a dash and 'No data' below the table for users.

@nurifreembd
Copy link
Collaborator Author

nurifreembd commented Dec 11, 2024 via email

@AlOneill
Copy link
Collaborator

If you are going to explain anything about the table, please add a heading to that explanation so that a screen reader user can discover it (without having to read the whole page).

@KristinaGadzhieva
Copy link
Collaborator

@AlOneill @richardofsussex @nurifreembd
Thank you. How about one of these headings: Table details / Table interpretation / Data navigation /Table navigation / How to read the table? / How to read the data?

@richardofsussex
Copy link

I must say, that starts to sound like [part of] a Help page. Maybe that is where such detailed advice should live? Personally I quite like the FreeReg results page layout, which has a brief summary of what you looked for and what we found, followed by a table of results. (You'll notice there is also a brief summary there of how to sort the results table.)

@KristinaGadzhieva
Copy link
Collaborator

Commented in #609: I have added information about 'No data' and dash (‘-’) cases to the Help MVP doc.
However, could we also add a short note for users under the table? It's easier to have clarification right under the table rather than searching for it on the Help page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MVP Minimum Viable Product (Requirement for launch) Results page
Projects
None yet
Development

No branches or pull requests

5 participants