Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of validation process step 4 (final step) #1790

Open
AnneV-Learn opened this issue Jun 23, 2024 · 5 comments
Open

Update of validation process step 4 (final step) #1790

AnneV-Learn opened this issue Jun 23, 2024 · 5 comments
Assignees

Comments

@AnneV-Learn
Copy link
Collaborator

AnneV-Learn commented Jun 23, 2024

When the freecen1_vld_entry_propagations collection was first created in was not envisaged that these pob propagations would be used by CSVProc data, so as the final step (Step 4) of the Strengthening of the Validation Process #1783 epic it would be advisable to rename the collection to freecen_pob_propagations to avoid future confusion.

This is likely to entail:

Renaming/migrating the freecen1_vld_entry_propagations collection data to freecen_pob_propagations and creating an index as was applied to freecen1_vld_entry_propagations.

Rename references in the associated model, views, controller and library entires (including Rakes) throughout all the project code.

@AnneV-Learn
Copy link
Collaborator Author

@geoffj-FUG
I am thinking it might be an idea to also add a 'Manage POB Propagation Records' Action in 'Your Actions' where POB Propagations could be viewed by anyone(?) and deleted by Data Manager or System Administrator (for hopefully the rare case were propagations are created by mistake)

@AnneV-Learn AnneV-Learn self-assigned this Aug 2, 2024
@geoffj-FUG
Copy link
Collaborator

geoffj-FUG commented Aug 3, 2024 via email

@AnneV-Learn
Copy link
Collaborator Author

AnneV-Learn commented Oct 28, 2024

@geoff I recommend that we delay this until the new CSV POB validation functionality (#1787 etc) has been live for at least a month, so that any 'teething' issues can be ironed out first.

@geoffj-FUG
Copy link
Collaborator

I am happy with that delay.
I have issued a preview of the changed instructions for validation and asked for feedback. One month should allow us to evaluate these instructions and any tweaking to do.
Once we are stable and the validation is up and going then we can implement this change.
Geoff

@AnneV-Learn
Copy link
Collaborator Author

@geoffj-FUG
The renaming of the POB Propagations collection has been successfully implemented on Test3.
I have also added a 'Manage POB Propagations' Action for County Coords, System Administrators and Data managers. It appears as an Action after having chosen the County to Manage. Only the POB Propagation records for Verbatim Birth County matching the County are displayed and the 'Show' screen offers a Delete button.
Not sure exactly what you want for 'Checkers/Validators' - just a View List of Propagations option as an action?.
Anyway, perhaps you can take a look and report back. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants