Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSVProc File Upload - List of users where file to be stored includes INACTIVE users #1795

Open
AnneV-Learn opened this issue Jul 2, 2024 · 9 comments

Comments

@AnneV-Learn
Copy link
Collaborator

No description provided.

@AnneV-Learn
Copy link
Collaborator Author

Whilst trying to resolve an issue that a coordinator and user were having with uploading/replacing a CSV file I noticed that the dropdown list of users where file is to be stored that Coords see includes INACTIVE users. I believe it should only show ACTIVE users.

@AnneV-Learn
Copy link
Collaborator Author

Fix now ready for testing on Test3

@geoffj-FUG
Copy link
Collaborator

Anne

Can I add a thought to that please? It should be active users within the county. But we do need an option to expand that to all active users (I have volunteers who are registered in one county but I use in other counties. Most Coordinators do.

Geoff

@AnneV-Learn
Copy link
Collaborator Author

@geoffj-FUG
Does ‘registered in one county’ mean volunteers in the county syndicate that matches the Admin county of the piece or something else?

@suffolkroots
Copy link

Anne---another thought---

Sometimes we need to do a correction then replace on a file owned by an inactive ID. Therefore they should be kept in the list?

@geoffj-FUG
Copy link
Collaborator

geoffj-FUG commented Jul 26, 2024 via email

@AnneV-Learn
Copy link
Collaborator Author

@geoffj-FUG
Maybe the best thing to do (since no one has actually complained about anything here) would be to just limit the change to the code so that ALL Users are listed if it is a REPLACE upload and only ACTIVE Userids are listed if it is a NEW upload.

@geoffj-FUG
Copy link
Collaborator

geoffj-FUG commented Aug 2, 2024 via email

@AnneV-Learn
Copy link
Collaborator Author

@geoffj-FUG
Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants