Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image placement / alignment doesn't work in 'multiple' mode #56

Open
DeniseColbert opened this issue Jun 21, 2019 · 4 comments
Open

Image placement / alignment doesn't work in 'multiple' mode #56

DeniseColbert opened this issue Jun 21, 2019 · 4 comments

Comments

@DeniseColbert
Copy link
Collaborator

I'm not sure 'multiple' mode is the correct name, I've circled it in the snip:

image.png

When selected (as here, on https://www.freeukgenealogy.org.uk/admin/entries/pages/2793-which-project) the 'left', 'centre' and 'right' toggle have no effect.

This will likely not be an issue in WP, but just logging it anyway.

@ghost
Copy link

ghost commented Jun 22, 2019

@DeniseColbert Craft refers to this display type as "grid", which would suggest to me that it's intended to fill the horizontal display area - a review of the ul.gallery-thumbs HTML and CSS declarations associated with this display type shows forced left alignment within the grid (though the container element for the grid does reflect the specified alignment, it's overridden with text-align: left !important).

Given that this appears to be intended operation, I'd consider this a "no fix" issue with Craft.

@DeniseColbert
Copy link
Collaborator Author

No probs. Can we leave it open to make sure we get image alignment controls (and sizing if poss) right in WP?

@ghost
Copy link

ghost commented Jun 24, 2019

@DeniseColbert I'd say that this issue stems from the Craft way of doing things (e.g. providing an alignment control for an element that overrides alignment) though you're welcome to leave open to confirm the effect can be accomplished in WordPress (can serve as reminder for me to provide instructions on how to use an appropriate Gutenberg block).

@DeniseColbert
Copy link
Collaborator Author

Yep, that's what I meant; thanks Gray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant