Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for images with white backgrounds and replace with transparent PNGs (was update background colour) #177

Open
DeniseColbert opened this issue Mar 25, 2021 · 5 comments
Assignees

Comments

@DeniseColbert
Copy link

@hotbeverage2017 (Gloria) will look at if this needs to be done in the theme, or the global settings in Elementor

@DeniseColbert
Copy link
Author

Gabriel has offered to look at this

@hotbeverage2017
Copy link
Collaborator

@Gabriel-Ludwig I have figured out how to change the background color of the new site from #ffffff to #fafafa. If you want to investigate and see if you can first figure it out, that's fine. It's not bad to wander around and see where it's at. Or, if you want some hints or for me to just tell you, that's fine, too. Just let me know.

@Gabriel-Ludwig
Copy link

@hotbeverage2017 I will try to figure it out, and if I need some hints I’ll let you know, thanks!

@Gabriel-Ludwig
Copy link

I just finished changing the background color to #fafafa as desired, moving it to design review

@DeniseColbert DeniseColbert changed the title Change background of page colour from #FFFFFF to #FAFAFA Check for images with white backgrounds and replace with transparent PNGs (was update background colour) May 12, 2021
@DeniseColbert
Copy link
Author

Great job, @Gabriel-Ludwig thanks!

Although now I notice that we have a problem with the project logos a bit further down the page:

image

I've renamed this story to reflect this, have requested versions of these icons with an outline from our design volunteer, to help with contrast. I'll update the story when we have them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants