Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build assets in shopware bundles #223

Closed
htuscher opened this issue Aug 28, 2023 · 4 comments
Closed

Build assets in shopware bundles #223

htuscher opened this issue Aug 28, 2023 · 4 comments

Comments

@htuscher
Copy link

Please describe the feature you would like to see implemented.

As described here https://shyim.me/blog/you-dont-need-a-plugin-to-customize-shopware-6/ you can also have a bundle which contains assets to build.

At the moment, you're only looking for the composer type shopware-platform-plugin which is not the case for a bundle (symfony-bundle).

if pkg.PackageType == "shopware-platform-plugin" {

Maybe you can introduce some kind of extra value that you're looking for which can also indicate for other composer package types that they contain assets?

@shyim
Copy link
Member

shyim commented Aug 28, 2023

We could check if that package contains a .shopware-extension.yaml 🤔

@tinect
Copy link
Member

tinect commented Aug 28, 2023

refs/duplicates #201 ?

@htuscher
Copy link
Author

Or have an additional list of folders in the .shopware-extension.yaml?
I'm not sure which solution would be best suited.

@shyim
Copy link
Member

shyim commented Sep 24, 2023

I close this as it's a duplicate of #201

@shyim shyim closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants