Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overrideFlexformSettingsIfEmpty does not work for hidePagination #345

Open
lisardo2 opened this issue Apr 6, 2021 · 2 comments
Open

overrideFlexformSettingsIfEmpty does not work for hidePagination #345

lisardo2 opened this issue Apr 6, 2021 · 2 comments

Comments

@lisardo2
Copy link

lisardo2 commented Apr 6, 2021

in function override this code should override the settings from the flexform:

if (((!isset($previousData[$fieldName]) || (string)$previousData[$fieldName] === '') || (strlen($previousData[$fieldName]) === 0)) && isset($tsData['settings'][$fieldName]) ) {

hidePagination from the flexform is either 0 or 1 - never empty and never with strlen === 0. So this term above could not become true and therfore it is now impossible to override hidePagination

@responseinformationsdesign

Seems to be similar to #421.

@georgringer
Copy link
Contributor

@responseinformationsdesign wanna do a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants