Skip to content

Commit 4563eb6

Browse files
authored
Merge pull request #337 from FromDoppler/dop-1520-save-content-links
Dop 1520 save content links
2 parents 420bfaf + 78537c0 commit 4563eb6

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

Doppler.HtmlEditorApi.Test/Domain/DopplerHtmlDocumentTest.cs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,22 @@ public void GetTrackableUrls_should_not_map_field_names()
307307
link => Assert.Equal("ftp://|*|3*|*", link));
308308
}
309309

310+
[Fact]
311+
public void GetTrackableUrls_remove_encoding_on_sanitize_to_save()
312+
{
313+
// Arrange
314+
var input = "<p><a href=\"https://midomain.com/?param1=aa&amp;param2=bb\">This is a link with parameters</a></p>";
315+
var htmlDocument = new DopplerHtmlDocument(input);
316+
htmlDocument.GetDopplerContent();
317+
htmlDocument.SanitizeTrackableLinks();
318+
319+
// Act
320+
var links = htmlDocument.GetTrackableUrls();
321+
322+
// Assert
323+
Assert.Equal("https://midomain.com/?param1=aa&param2=bb", links.FirstOrDefault());
324+
}
325+
310326
[Theory]
311327
[InlineDataAttribute(
312328
@"

Doppler.HtmlEditorApi/Domain/DopplerHtmlDocument.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ private static string SanitizedUrl(string url)
151151
var domain = match.Groups["domain"].Value
152152
.FallbackIfNullOrEmpty(match.Groups["domainWithoutScheme"].Value)
153153
.ToLowerInvariant();
154-
var rest = match.Groups["rest"].Value;
154+
var rest = match.Groups["rest"].Value.Replace("&amp;", "&");
155155
var sanitizedUrl = $"{scheme}{domain}{rest}";
156156

157157
return sanitizedUrl;

0 commit comments

Comments
 (0)