Broken player spells

[Frostshake]

• Druid
  • mark of the wild ranks possible at same time (i suspect this applies to other buff types too)
    • see vmanogs bool Unit::RemoveNoStackAurasDueToAuraHolder(SpellAuraHolder* holder) , SpellMgr.IsNoStackSpellDueToSpell
    • see 3.3.5 _RemoveNoStackAurasDueToAura, Aura::CanStackWith
    • Tranquility doesnt channel correctly / ends early. c76c8f0
    • Hurricane channel ends early too.
    • swiftmend doesnt appear to work.
    • natures swiftness not consumed on use.
    • mana bar shown while in bear form. 926b2c1
• Hunter
  • shooting weapon doesnt consume ammo 9597aa7
  • Multiple aspects are possible at once. 926b2c1
  • tame pet doesnt work
• Mage
  • cold snap doesnt reset frost cooldowns - 68aad4f
  • casting slow fall disconnects client.
  • casting polymorph will trigger ignite.
  • arcane missiles no longer works (was working) 40b7b28
• Paladin
  • Holy light doesnt heal, but does consume mana.
    • Spell::HandleEffects should trigger Spell::EffectHeal, effect SPELL_EFFECT_HEAL
    • appears wotlk had this as effect 10, but 1.12 and 1.14 have this as 77 (script)
    • seems vmangos has a 'spell_effect_mod' which specifically changes holy light from 77 to 10.
  • devotion aura appears twice on action bar once leveled up 8d4044f
    • learning a new rank of aura spell should unlearn the previous rank.
  • Forbearance not applied bbd5169
  • multiple resistance auras possible at once. 926b2c1
  • Multiple blessings possible on single target
    • spell_group & spell_group_stack_rules need updating for classic spells (all spells)
• Priest
  • Levitate cloud effect isnt kept while moving (not actual problem, 1.12 does this too)
  • mind control doesnt change action bar
• Rogue
  • stealth doesnt give correct character animation
    • looks to be related to UNIT_FIELD_BYTES_1 and UnitStandFlags
  • stealth has incorrect cooldown, UI shows correct, but server thinks its ~ 30 days. 2a4ab11
  • sap triggers combat. (strangely appears to work with GM mode on) 10f55c4
  • improved sap not working d40157b
  • pickpocket causes server crash. accfc87
  • multiple stealth icons on action bar.
  • combo points not shown. 7127667
  • energy doesnt regenerate in combat c7c6d6f
  • combopoints remains on dead target
  • some rogue abilities reset the enemy when in combat. d40157b
• Warrior
  • blood rage causes index access error. 03a5483
  • blood thrist doesnt heal.
• warlock
  • learn my trainer causes client crash / stackoverflow - caused by learning spell 1010, also causes crash using hermes. 148ae70
  • life tap doesnt work.
  • imp doesnt cast firebolt, but does melee combat
  • drain soul effect targets the player instead of the enemy (same with all drain * effects) - Looks to be related to new obj update system, old works ok.
  • creating a soul shard on an enemy doesnt kill them, yeh just stand and look at you while in combat (invalid target) (possibly client issue, logout and login will show them as dead)
  • logout and login with pet active, the pet will exist, but action bar will be missing.
  • additional soul shards added to bag after logout + login
  • eye of kilrogg doesnt move camera
  • demon skin / armour possible at same time. 926b2c1
  • drain soul causes server crash (nullptr problem) not cast for full duration (appears to be removed instantly). 139cd38