Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check / validate spell data #41

Open
Frostshake opened this issue Oct 27, 2024 · 0 comments
Open

Check / validate spell data #41

Frostshake opened this issue Oct 27, 2024 · 0 comments
Labels
bug Something isn't working Data Spell

Comments

@Frostshake
Copy link
Owner

Frostshake commented Oct 27, 2024

Noticed today that spell ids change between expansions, e.g iceblock, cold snap.

This means that anything using spell id will need to be overwritten with vmangos data or checked.

This that come to mind:

  • spell_ranks table
  • spell_script_names table
  • any spell id enums/constants.
  • spell_group / spell_group_stack_rules

As part of this, need to check how many spells are missng from the client data that used.
Modern TC only used db2 spells, but vmanogs & 3.3.5 TC use a sql table, I expect this is because previously there were many spells not in the client data.
If only a few spells need to be manually defined, then in might be easier to code directly, but if many, then update code to include additional spells from table.
For example WL life tap is spell 31818, but missing in data.

@Frostshake Frostshake added bug Something isn't working Spell Data labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Data Spell
Projects
None yet
Development

No branches or pull requests

1 participant