From 447bb4a907c560ce523a295bfb91a9d5bdf075c4 Mon Sep 17 00:00:00 2001 From: Jakub Kadlcik Date: Thu, 10 Aug 2023 15:59:04 +0200 Subject: [PATCH] rpmbuild: save review.json from fedora-review See https://pagure.io/FedoraReview/pull-request/463 See https://pagure.io/FedoraReview/issue/310 I am planning to use this file from the fedora-review-service and provide users better feedback based on that. Also, we don't need to depend on a specific fedora-review version. If the file is not present, we skip it without failing. --- rpmbuild/copr_rpmbuild/automation/fedora_review.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rpmbuild/copr_rpmbuild/automation/fedora_review.py b/rpmbuild/copr_rpmbuild/automation/fedora_review.py index 0d9dd91ee..006e75d70 100644 --- a/rpmbuild/copr_rpmbuild/automation/fedora_review.py +++ b/rpmbuild/copr_rpmbuild/automation/fedora_review.py @@ -73,7 +73,8 @@ def _filter_results_directory(self): self.log.error("Can't find fedora-review results: %s", srcdir) return - results = ["review.txt", "licensecheck.txt", "rpmlint.txt", "files.dir"] + results = ["review.txt", "review.json", "licensecheck.txt", + "rpmlint.txt", "files.dir"] for result in results: try: os.rename(os.path.join(srcdir, result),