Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing assetId: 0x0000... of call receipt returned from graphql #1941

Open
LuizAsFight opened this issue Jun 6, 2024 · 0 comments

Comments

@LuizAsFight
Copy link

Context

if you execute this query

query {
  transaction(id:"0xb3db00fb8261984407c7b308e926d4a928fa401eaf1c89c848a1733333128181") {
    status {
      __typename
      ... on SuccessStatus {
        receipts {
          __typename
          assetId
          amount
        }
      }
    }
  }

this contract call had no assets sent to it, therefore the assetId is returned as 0x0000....

Suggestion

Return assetId: null in this situation. I think it represents better that call didn't have an asset
Also as the baseAssetId of a network can be 0x0000... too, leads to confusion like "it represents the asset or null?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant