-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blob tx support and fuel-vm 0.56.0 #1988
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just the one comment.
assert!(matches!(status, TransactionStatus::Success { .. })); | ||
|
||
// When | ||
let script_tx = TransactionBuilder::script( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using new_blob
shouldn't the "when" of this test be sending the Blob
tx?
The bsiz
is just how you chose to verify that the blob is callable, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and yes. Fixed in a0bdfcc.
@@ -119,6 +119,7 @@ | |||
} | |||
], | |||
"messages": [], | |||
"blobs": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't break state config. The blobs
should be Option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blobs
is #[serde(default)]
. Isn't this enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with a local node connected to testnet that serde(default) works 👍🏻
@@ -801,6 +801,7 @@ mod tests { | |||
StateConfig { | |||
coins: vec![], | |||
messages: vec![], | |||
blobs: vec![], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be None
crates/client/assets/schema.sdl
Outdated
@@ -357,7 +359,6 @@ type GasCosts { | |||
divi: U64! | |||
ecr1: U64! | |||
eck1: U64! | |||
ed19: U64! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't remove old ed19
. Because of backward compatibility we need to add ed19DependentCost
. As we did for aloc
opcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed in ebe4c21, let me know if that looks correct.
## What's Changed * L2 Block Source & Metadata Storage implementations by @MitchTurner in #1983 * Weekly `cargo update` by @github-actions in #2029 * Add V0 algorithm to actual services by @MitchTurner in #2025 * Weekly `cargo update` by @github-actions in #2039 * Add syncronization for Gas Price Database and On Chain Database on startup by @MitchTurner in #2041 * Ignore the message receipt if transaction is reverted by @xgreenx in #2045 * feat: add chain config to Docker images by @mchristopher in #2052 * Blob tx support and fuel-vm 0.56.0 by @Dentosal in #1988 * Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in #2048 ## New Contributors * @mchristopher made their first contribution in #2052 **Full Changelog**: v0.31.0...v0.32.0
Work towards FuelLabs/fuel-specs#589. Spec PR FuelLabs/fuel-specs#592.
Adds support for Blob transactions, which are inserted into the onchain database column called
Blobs
.Also updates fuel-vm to 0.56.0, which introduces the new tx type.
Work-in-progress, still needs:
Checklist
Before requesting review
After merging, notify other teams