Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallReceipt is returning wrong from property #2449

Open
LuizAsFight opened this issue Jun 6, 2024 · 3 comments
Open

CallReceipt is returning wrong from property #2449

LuizAsFight opened this issue Jun 6, 2024 · 3 comments
Labels
bug Issue is a bug p1 Medium priority

Comments

@LuizAsFight
Copy link
Contributor

Motivation

Contract Call receipts are getting a from property
I think from is not correct for this receipt. It should be id like in other case inside that same switch, or it should be removed.

reasons according to spec :
1- shows Call contracts prop already have a from prop
2- there is no contractId and no id in CallReceipt, which means the from being provided by this method will be always 0x0000...

Usage example

No response

Possible implementations

No response

@arboleya arboleya added bug Issue is a bug triage Issue needs to be triaged labels Jun 9, 2024
@petertonysmith94
Copy link
Contributor

Summary

  • I agree with this assessment that the from property should be changed to id.
  • It seems like the from property isn't even returned - I do question if the spec's are also off?
  • I also looked over the Transfer and TransferOut and they also have a similar issue (from what I understand).

Call

Transfer

TransferOut

@petertonysmith94 petertonysmith94 self-assigned this Jun 12, 2024
@petertonysmith94
Copy link
Contributor

@danielbate you mentioned in sync about other possible mismatches?

@petertonysmith94 petertonysmith94 added p1 Medium priority and removed triage Issue needs to be triaged labels Jun 17, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x post-launch milestone Jun 17, 2024
@danielbate
Copy link
Contributor

I believe #2530 and #2448 are related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug p1 Medium priority
Projects
None yet
Development

No branches or pull requests

4 participants