Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callParams asset forwarding API feedback #3591

Open
Dhaiwat10 opened this issue Jan 15, 2025 · 0 comments
Open

callParams asset forwarding API feedback #3591

Dhaiwat10 opened this issue Jan 15, 2025 · 0 comments

Comments

@Dhaiwat10
Copy link
Member

Currently there are two ways of specifying a CoinQuantityLike which is the type expected by forward:

type CoinQuantityLike = [amount: BigNumberish, assetId: BytesLike, max?: BigNumberish] | {
amount: BigNumberish;
assetId: BytesLike;
max?: BigNumberish;
};

This leads to unclear auto-complete and gives users an unnecessary extra choice. I propose removing the array syntax, the object syntax is more clear:

type CoinQuantityLike = {
amount: BigNumberish;
assetId: BytesLike;
max?: BigNumberish;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant