We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently there are two ways of specifying a CoinQuantityLike which is the type expected by forward:
type CoinQuantityLike = [amount: BigNumberish, assetId: BytesLike, max?: BigNumberish] | { amount: BigNumberish; assetId: BytesLike; max?: BigNumberish; };
This leads to unclear auto-complete and gives users an unnecessary extra choice. I propose removing the array syntax, the object syntax is more clear:
type CoinQuantityLike = { amount: BigNumberish; assetId: BytesLike; max?: BigNumberish; };
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Currently there are two ways of specifying a CoinQuantityLike which is the type expected by forward:
type CoinQuantityLike = [amount: BigNumberish, assetId: BytesLike, max?: BigNumberish] | {
amount: BigNumberish;
assetId: BytesLike;
max?: BigNumberish;
};
This leads to unclear auto-complete and gives users an unnecessary extra choice. I propose removing the array syntax, the object syntax is more clear:
type CoinQuantityLike = {
amount: BigNumberish;
assetId: BytesLike;
max?: BigNumberish;
};
The text was updated successfully, but these errors were encountered: