Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use GitHub application token #3616

Merged
merged 26 commits into from
Feb 18, 2025
Merged

chore: use GitHub application token #3616

merged 26 commits into from
Feb 18, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 23, 2025 •
edited
Loading

Summary

  • Migrate GITHUB_TOKEN usage to use an application token for cross-repository operations.
  • The INTERNAL application should enable the automatic triggering of our changeset release PR workflows. These workflows require manual approval with the current implementation (default GITHUB_TOKEN).

Applications configuration

  • GitHub application (internal)

    • Environmental
      • vars. APP_ID
      • secrets.APP_KEY
    • Permissions:
      • Contents: Read + Write
      • Pull requests: Read + Write
      • Issues: Read

  • GitHub application (docs)

    • Environmental
      • vars. FUEL_DOCS_BOT_APP_ID
      • secrets. FUEL_DOCS_BOT_APP_KEY
    • Permissions:
      • Actions: Read+Write
        • FuelLabs/docs-hub
        • FuelLabs/migrations-and-disclosures

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Jan 23, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 23, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 7:00pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 7:00pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 7:00pm

petertonysmith94
petertonysmith94 commented Jan 23, 2025
View reviewed changes
Copy link
Contributor Author

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotating permissions required for release application

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@petertonysmith94 petertonysmith94 mentioned this pull request Jan 23, 2025
Closed
mchristopher
mchristopher reviewed Jan 31, 2025
View reviewed changes
.github/workflows/pr-validate-changesets.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@petertonysmith94 petertonysmith94 marked this pull request as ready for review February 4, 2025 16:58
@petertonysmith94 petertonysmith94 enabled auto-merge (squash) February 18, 2025 18:51
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.13%(-0.02%) 70.81%(+0.12%) 75.23%(-0.07%) 77.13%(-0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ packages/abi-coder/src/utils/scriptData.ts 0%
(+0%)		 0%
(+0%)		 0%
(+0%)		 0%
(+0%)
🔴 packages/account/src/account.ts 81.03%
(+0.45%)		 72%
(+0.77%)		 82.5%
(+0%)		 80.79%
(+0.45%)
🔴 packages/account/src/connectors/fuel-connector.ts 30%
(+1.43%)		 100%
(+0%)		 4.54%
(-0.22%)		 30%
(+1.43%)
🔴 packages/account/src/connectors/fuel.ts 96.75%
(+0.02%)		 90.66%
(+0%)		 93.33%
(+0%)		 96.87%
(+0.02%)
🔴 packages/account/src/providers/provider.ts 67.53%
(+0.58%)		 59.8%
(+2.73%)		 68.04%
(+0%)		 67.29%
(+0.56%)
🔴 packages/errors/src/test-utils/expect-to-throw-fuel-error.ts 91.66%
(-0.34%)		 88.88%
(+0%)		 100%
(+0%)		 91.66%
(-0.34%)

@petertonysmith94 petertonysmith94 merged commit 4a26957 into master Feb 18, 2025
25 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/use-github-application-token branch February 18, 2025 19:13
@petertonysmith94 petertonysmith94 mentioned this pull request Feb 19, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchristopher mchristopher mchristopher approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@arboleya arboleya arboleya left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate PAT GitHub Token Usage
5 participants
@petertonysmith94 @arboleya @mchristopher @nedsalk @Torres-ssf