Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction ID not correctly set on Contract input #3708

Open
danielbate opened this issue Feb 14, 2025 · 2 comments
Open

Transaction ID not correctly set on Contract input #3708

danielbate opened this issue Feb 14, 2025 · 2 comments
Labels
bug Issue is a bug

Comments

@danielbate
Copy link
Member

When we create a new contract input against a transaction, we always zero out the transaction ID.

This has not been a problem because this value is meant to be zeroed out for hashing/signing.

However when building out a transaction summary from a transaction response (transactionResponse.getTransactionSummary()) the summary is technically not correct as this input has not been populated correctly. Whereas a summary generated using a transaction ID (getTransactionSummary(txId)) fetches the full tx from the node, has this input set correctly.

@Torres-ssf
Copy link
Contributor

Torres-ssf commented Feb 17, 2025

I believe this happens because we no longer fetch the transaction within TransactionResponse when a transaction request is given during its instantiation.

Instead, we update specific parts of it using data from the subscription result.

cc @nedsalk

@danielbate
Copy link
Member Author

Once this has been completed, we should enable the tests in #3710.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

No branches or pull requests

2 participants