Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix receipts properties and deprecate incorrect ones #3385

Merged
merged 11 commits into from
Nov 13, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Nov 12, 2024

Release notes

In this release, we:

  • Deprecate and fix multiple receipts properties

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added the bug Issue is a bug label Nov 12, 2024
@Torres-ssf Torres-ssf self-assigned this Nov 12, 2024
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:02am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:02am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ts-docs-api ⬜️ Ignored (Inspect) Nov 13, 2024 10:02am

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #3385 will not alter performance

Comparing st/chore/deprecate-receipts-properties (430c9ed) with master (2b624a1)

Summary

✅ 18 untouched benchmarks

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Torres-ssf 🚀

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
64.34%(+0.03%) 69.61%(+0%) 73.32%(+0%) 64.78%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/utils/receipts.ts 95.31%
(+0.77%)
72%
(+0%)
100%
(+0%)
95.38%
(+0.74%)

@Torres-ssf Torres-ssf enabled auto-merge (squash) November 13, 2024 11:33
@Torres-ssf Torres-ssf merged commit 1226ac3 into master Nov 13, 2024
25 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/deprecate-receipts-properties branch November 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CallReceipt is returning wrong from property
5 participants