Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one Combine target and remove Cocoapods & UIKIt files #86

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

hadiidbouk
Copy link
Collaborator

Issue Link 🔗

Goals ⚽

The goal of this PR is to remove deprecation tools and reduce the targets. We are not using Cocoapods anymore neither UIKit. In addition, we will fully adopt Swift Concurrency in the future so it doesn't make sense to expand too much in the reactive solutions like Combine.

Backwards-compatibility:

From The new version and upwards:

  • There will be only one target for Combine (FueledUtilsCombine).
  • No Cocoapods Support
  • No UIKit Helpers.

Implementation Details 🚧

  • Use one Combine target (FueledUtilsCombine) instead of FueledUtilsReactiveCommon & FueledUtilsCombineOperators.
  • Remove Cocoapods support and related files.
  • Remove UIKit helpers files.
  • Add two test targets instead of a big one that contains everything.

Testing Details 🔍

  • I removed Pods from testing.
  • We have two separate targets for testing, FueledUtilsCoreTests and FueledUtilsCombineTests.

@hadiidbouk hadiidbouk requested a review from a team November 10, 2023 13:02
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.

Here's an example of your CHANGELOG entry:

- Use one combine target and remove Podfile & UIKIt files  
  [hadiidbouk](https://github.com/hadiidbouk)
  [#pull_request_number](https://github.com/Fueled/ios-utilities/pulls/pull_request_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@hadiidbouk hadiidbouk changed the title Use one combine target and remove Podfile & UIKIt files Use one Combine target and remove Cocoapods & UIKIt files Nov 10, 2023
@hadiidbouk hadiidbouk added WIP and removed WIP labels Nov 13, 2023
Copy link
Member

@Sissing Sissing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice cleanup!

Copy link

@vinaykharb vinaykharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

Copy link

@ahujamanish ahujamanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@hadiidbouk hadiidbouk merged commit 392991c into develop Nov 15, 2023
3 checks passed
@robdeans robdeans deleted the chore/reduce-targets-and-delete-deprecation branch December 6, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants