Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OrderedSet since it's now available in swift-collections #88

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

hadiidbouk
Copy link
Collaborator

Issue Link πŸ”—

Goals ⚽

Remove the OrderedSet implementation

Backwards-compatibility:

No need for backward compatibility.

Implementation Details 🚧

It's enough to implement the swift-collection OrderedSet instead.

Testing Details πŸ”

@hadiidbouk hadiidbouk requested a review from a team November 16, 2023 09:08
@hadiidbouk hadiidbouk force-pushed the refactor/remove-ordered-set branch from 5b299f0 to b500bf4 Compare November 16, 2023 18:01
@hadiidbouk hadiidbouk force-pushed the refactor/remove-ordered-set branch from b500bf4 to f952961 Compare November 17, 2023 07:39
@hadiidbouk hadiidbouk merged commit 580e55d into develop Nov 17, 2023
3 checks passed
@robdeans robdeans deleted the refactor/remove-ordered-set branch December 6, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants