Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization constants for edge features during inference #13

Open
hitarth64 opened this issue Mar 20, 2023 · 0 comments
Open

Normalization constants for edge features during inference #13

hitarth64 opened this issue Mar 20, 2023 · 0 comments

Comments

@hitarth64
Copy link

Hi @vxfung!

Hoping you are well!

Just wanted to bring to notice a minor issue I faced while trying to integrate MatDeepLearn with one of my custom packages. Currently, while processing the ASE structures, edge normalization happens as per the interatomic distance distribution of the input data features.

However, for the prediction or inference phase, this should not be the case. Especially, I found that for smaller datasets where crystal structures were similar, the normalization constants could be different from what were used for learning, and that resulted in inconsistent predictions. This is likely to happen only in cases where we have a set of crystal structures with interatomic distances less than the ones set in graph processing; and therefore, only when you are predicting properties for a small set of similar structures.

A couple of proposed fixes:

  • Set the Min-Max normalization constants to be the same as what is set in the graph processing config
    OR
  • Enforce it as a required field for inference/prediction jobs

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant