Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3rd Party Links in Footer | Missing Validation in Newsletter | No Submit Button in Footer | No Newsletter Service Attached | React Toast Alerts Missing | Useless Redirection of Footer Links | Linking to Correct Pages of the Website #172

Closed
Shariq2003 opened this issue Oct 25, 2024 · 3 comments · Fixed by #202
Closed

3rd Party Links in Footer | Missing Validation in Newsletter | No Submit Button in Footer | No Newsletter Service Attached | React Toast Alerts Missing | Useless Redirection of Footer Links | Linking to Correct Pages of the Website #172

Shariq2003 opened this issue Oct 25, 2024 · 3 comments · Fixed by #202
Assignees
@Shariq2003
Labels
gssoc-ext level3

Comments

@Shariq2003
Copy link
Contributor

Shariq2003 commented Oct 25, 2024 •
edited
Loading

  1. Currently, the Footer is redirecting to 3rd party websites on clicking any link in the footer (even of pages links).
    That should be link to the correct pages of the website.

  2. Missing Validation in Footer's Newsletter.

  3. No submit button in Newsletter.

  4. No React Toast Popups.

  5. No Newsletter Serviece Attached.

image

bandicam.2024-10-26.03-36-44-700.mp4
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for raising an issue in this repository!
We’ll review and assign it to you soon.
In the meantime, feel free to ⭐ the repo for updates.
Stay awesome! 😎

@Shariq2003 Shariq2003 changed the title 3rd Party Links in Footer | Useless Redirection of Footer Links | Linking to Correct Pages of the Website 3rd Party Links in Footer | Missing Validation in Newsletter | No Submit Button in Footer | No Newsletter Service Attached | React Toast Alerts Missing | Useless Redirection of Footer Links | Linking to Correct Pages of the Website Oct 25, 2024
@rishicds
Copy link
Collaborator

Assigned

This was referenced Oct 26, 2024
Closed
Closed
Merged
rishicds added a commit that referenced this issue Oct 27, 2024
@rishicds
Merge pull request #202 from Shariq2003/FooterFixes
db79f79 
Fixes :: Removed 3rd Party Links in Footer | Added Missing Validation in Newsletter | Added Submit Button in Newsletter | Added Newsletter Service | React Toast Alerts Added | Redirection Linking to Correct Pages of the Website | Issue #172
@github-actions GitHub Actions
Copy link
Contributor

Hello @Shariq2003! Your issue #172 has been closed. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shariq2003 Shariq2003

Labels
gssoc-ext level3
Projects
None yet
Milestone
No milestone
2 participants
@Shariq2003 @rishicds