Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Issue: Illegal MAPL_GetResource calls #331

Open
mathomp4 opened this issue Sep 24, 2021 · 1 comment
Open

Meta Issue: Illegal MAPL_GetResource calls #331

mathomp4 opened this issue Sep 24, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mathomp4
Copy link
Member

As seen in GEOS-ESM/GEOSgcm_GridComp#459, there are some illegal MAPL_GetResource calls a la:

    call MAPL_GetResource(MAPL,Ncolumns,LABEL="SATSIM_NCOLUMNS:",default=Ncolumns,  RC=STATUS)

where the output is also an input. This issue will track possible lines that need fixed.

@mathomp4 mathomp4 added the bug Something isn't working label Sep 24, 2021
@mathomp4 mathomp4 self-assigned this Sep 24, 2021
@mathomp4
Copy link
Member Author

GEOSseaice_GridComp/GEOSCICEDyna_GridComp/GEOS_CICEDynaGridComp.F90:

1538:    call MAPL_GetResource ( MAPL, DTI, Label="CICE_DT:", DEFAULT=DTI, RC=STATUS)
2257:    call MAPL_GetResource (STATE, DT, Label="CICE_DT:", DEFAULT=DT, RC=STATUS)

GEOS_mkiauGridComp.F90:

805:    call MAPL_GetResource(MAPL, REPLAY_TS,     Label="REPLAY_TS:",     default=trim(REPLAY_TS), RC=STATUS)

GEOS_DataAtmGridComp.F90:

2230:    call MAPL_GetResource ( STATE, DT, Label="DT:", DEFAULT=DT, RC=STATUS)

GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSlake_GridComp/GEOS_LakeGridComp.F90

1626:    call MAPL_GetResource ( MAPL, DT, Label="DT:", DEFAULT=DT, RC=STATUS)

GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSsaltwater_GridComp/GEOS_SimpleSeaiceGridComp.F90

2144:    call MAPL_GetResource ( MAPL, DT, Label="DT:", DEFAULT=DT, RC=STATUS)

GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSsaltwater_GridComp/GEOS_OpenWaterGridComp.F90

1677:    call MAPL_GetResource ( MAPL, DT, Label="DT:", DEFAULT=DT, RC=STATUS)
2549:    call MAPL_GetResource ( MAPL, DT, Label="DT:", DEFAULT=DT, RC=STATUS)

GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSsaltwater_GridComp/GEOS_CICE4ColumnPhysGridComp.F90

2386:    call MAPL_GetResource ( MAPL, DT, Label="DT:", DEFAULT=DT, RC=STATUS)
3588:    call MAPL_GetResource ( MAPL, DT, Label="DT:", DEFAULT=DT, RC=STATUS)

GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSlandice_GridComp/GEOS_LandIceGridComp.F90

2601:    call MAPL_GetResource ( MAPL, DT, Label="DT:", DEFAULT=DT, RC=STATUS)

GEOSsuperdyn_GridComp/@FVdycoreCubed_GridComp/FV_StateMod.F90

402:  call MAPL_GetResource( MAPL, AdvCore_Advection, label='AdvCore_Advection:', default=AdvCore_Advection, rc=status )
405:  call MAPL_GetResource( MAPL, INT_fix_mass,    label='fix_mass:'    , default=INT_fix_mass, rc=status )
406:  call MAPL_GetResource( MAPL, INT_check_mass,  label='check_mass:'  , default=INT_check_mass, rc=status )
407:  call MAPL_GetResource( MAPL, INT_ADIABATIC,   label='ADIABATIC:'   , default=INT_adiabatic, rc=status )
408:  call MAPL_GetResource( MAPL, INT_FV_OFF,      label='FV_OFF:'      , default=INT_FV_OFF, rc=status )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant