MAPL3: Move to implicit none type external #3100
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests
)Description
This is the MAPL3 version of #3002 . We don't expect to ever build MAPL3 with
nvfortran
so the issues withimplicit none (type, external)
are moot.This PR updates MAPL3 to use
implicit none (type, external)
in most of MAPL andimplicit none (type)
in places with:use mpi
netcdf.inc
It seems to pass a local build. Now to see what CI thinks.
Related Issue