Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAPL3: Move to implicit none type external #3100

Closed

Conversation

mathomp4
Copy link
Member

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This is the MAPL3 version of #3002 . We don't expect to ever build MAPL3 with nvfortran so the issues with implicit none (type, external) are moot.

This PR updates MAPL3 to use implicit none (type, external) in most of MAPL and implicit none (type) in places with:

  • use mpi
  • use of netcdf.inc
  • One place with OpenMP (I think)

It seems to pass a local build. Now to see what CI thinks.

Related Issue

@mathomp4 mathomp4 added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 16, 2024
@mathomp4 mathomp4 self-assigned this Oct 16, 2024
@mathomp4 mathomp4 closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant