Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BlockIdentifier Message Type #138

Open
GGist opened this issue Nov 24, 2017 · 1 comment
Open

Create BlockIdentifier Message Type #138

GGist opened this issue Nov 24, 2017 · 1 comment

Comments

@GGist
Copy link
Owner

GGist commented Nov 24, 2017

Sometimes bip_select needs to tell clients to send a PieceMessage, but it wont know the actual payload. The clients will generally have to use something like bip_disk to get the payload from some fs to actually send the message.

We want bip_select to send a variant of PieceMessage without the data portion so clients dont get confused and think they can send that message without grabbing the data first. A wrapper type named something like BlockIdentifier would allow this, and we could use this type internally in RequestMessage, CancelMessage, as well as PieceMessage.

@GGist
Copy link
Owner Author

GGist commented Nov 24, 2017

For tighter integration, we could also re-use bip_disks BlockMetadata type.

This would be even better if we separated these vocabulary types out into a separate crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant