Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NPE caused by error handling code #1925

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

takb
Copy link
Contributor

@takb takb commented Dec 3, 2024

Pull Request Checklist

  • 1. I have [rebased][rebase] the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the [ors config documentation][config]
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground [renders correctly][api].

Fixes #1923 .

@github-actions github-actions bot added the fix label Dec 3, 2024
@takb takb force-pushed the fix/npe-in-error-handling branch from 0a4a7e5 to 78c9e77 Compare December 3, 2024 15:44
@takb takb marked this pull request as ready for review December 3, 2024 15:45
@github-actions github-actions bot added fix and removed fix labels Dec 3, 2024
@takb takb requested a review from koebi December 3, 2024 15:46
@github-actions github-actions bot added fix and removed fix labels Dec 3, 2024
Copy link

sonarcloud bot commented Dec 3, 2024

Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koebi koebi merged commit b95a1c8 into main Dec 3, 2024
52 checks passed
@koebi koebi deleted the fix/npe-in-error-handling branch December 3, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null Pointer Exception due to error in getLocalizedMessage()
2 participants