-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button to enter command #287
Comments
@justinlaughlin, it may be more convenient to open a WIP/Draft PR for your branch https://github.com/GLVis/glvis/tree/number-formatting, and have the discussion there -- at least if you think you want to address this topic there. If the topic here will be addressed in a separate branch (or multiple branches), then keeping this separate from the |
Here are a few options for the key that opens the "command mode":
|
I like all of :, Esc and Tab. I'd prefer we don't change Enter |
It may be nice to have a dedicated button that would then let you type in a command into the terminal, e.g.
format
. The idea is something similar to:
in vim orCtrl+Shift+P
in vscode.:
is an unused key at the moment and a potential candidate.Some keys already require additional user input into the terminal (e.g.
F5
). Currently this is done usingcin >>
(ref) but this can lead to GLVis freezing if something erroneous is input (e.g. a string when a number is expected). I have a minimalprompt()
function that could maybe be a starting point for input type checking and validation (ref).For now, the easiest implementation would require inputting the command into the terminal, but eventually it would be nice to be able to directly input the command into the GLVis window.
The text was updated successfully, but these errors were encountered: