Add error message if no matching refName found

Author: garrettjstevens

packages/core/data_adapters/BaseAdapter.ts

@@ -168,7 +168,11 @@ export abstract class BaseFeatureDataAdapter extends BaseAdapter {
       const hasData = await this.hasDataForRefName(region.refName, opts)
       checkAbortSignal(opts.signal)
       if (!hasData) {
-        observer.complete()
+        observer.error(
+          new Error(
+            `refName "${region.refName}" not found. You may need to configure refName aliases.`,
+          ),
+        )
       } else {
         this.getFeatures(region, opts).subscribe(observer)
       }
@@ -208,6 +212,11 @@ export abstract class BaseFeatureDataAdapter extends BaseAdapter {
    */
   public async hasDataForRefName(refName: string, opts: BaseOptions = {}) {
     const refNames = await this.getRefNames(opts)
+    // If refNames are not available, fall back to `true` since `false` may
+    // cause errors even if a refName is available
+    if (!refNames.length) {
+      return true
+    }
     return refNames.includes(refName)
   }
 

packages/core/pluggableElementTypes/renderers/FeatureRendererType.ts

@@ -171,7 +171,7 @@ export default class FeatureRendererType extends ServerSideRendererType {
 
     const featureObservable =
       requestRegions.length === 1
-        ? dataAdapter.getFeatures(
+        ? dataAdapter.getFeaturesInRegion(
             this.getExpandedRegion(region, renderArgs),
             renderArgs,
           )