Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define hazard_config for default models with a file #102

Open
3 tasks done
chrisdicaprio opened this issue Aug 13, 2024 · 0 comments
Open
3 tasks done

define hazard_config for default models with a file #102

chrisdicaprio opened this issue Aug 13, 2024 · 0 comments
Assignees
Labels
LIB for filtering nzshm-model for filtering

Comments

@chrisdicaprio
Copy link
Collaborator

chrisdicaprio commented Aug 13, 2024

"official" models are defined with this pattern:

model_args: Dict[str, Any] = dict(
    version='NSHM_v1.0.4',
    title="NSHM version 1.0.4, corrected fault geometry",
    slt_json="nshm_v1.0.4_v2.json",
    gmm_json="gmcm_nshm_v1.0.4.json",
    gmm_xml="NZ_NSHM_GMM_LT_final_EE_new_names.xml",
    hazard_config=copy.deepcopy(OpenquakeConfig(DEFAULT_HAZARD_CONFIG)),
)

For symmetry and cleaner typing, it would be nice to define the hazard_config with a file like the other parameters

requires ability to serialize/deserialize config objects #103

done when:

@chrisdicaprio chrisdicaprio added the LIB for filtering label Aug 13, 2024
@chrisdicaprio chrisdicaprio self-assigned this Dec 6, 2024
@chrisdicaprio chrisdicaprio added the nzshm-model for filtering label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LIB for filtering nzshm-model for filtering
Projects
None yet
Development

No branches or pull requests

1 participant