Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Simplify tectonic region for user defined logic trees #67

Open
chrisdicaprio opened this issue Apr 9, 2024 · 0 comments
Open
Labels
LIB for filtering nzshm-model for filtering

Comments

@chrisdicaprio
Copy link
Collaborator

Background

The tectonic_region_type and tectonic_region_types are fields of GMCMBranch and SourceBranch. For a particular BranchSet these fields must mach.

Problem

If a user were to hand-build a logic tree, this requires a lot of redundant fields to be hand-entered which is both tedous and error prone

Solution

We want to modify serialization and de-serialization of LogicTrees such that the tectonic region type fields can be defined at the branch set level for ease of use. Actual implimentation of the class is to remain with the fields on the branches. This is needed due to how combined branches are used in toshi-hazard-post

@chrisdicaprio chrisdicaprio added nzshm-model for filtering LIB for filtering labels Apr 9, 2024
@chrisdicaprio chrisdicaprio changed the title Simplify tectonic region for user defined logic trees Proposal: Simplify tectonic region for user defined logic trees May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LIB for filtering nzshm-model for filtering
Projects
None yet
Development

No branches or pull requests

1 participant