Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE: new version source logic trees and backwards compatability for source_solution_id #81

Open
4 tasks
chrisbc opened this issue Jun 25, 2024 · 0 comments
Labels
LIB for filtering nzshm-model for filtering

Comments

@chrisbc
Copy link
Member

chrisbc commented Jun 25, 2024

For discussion @chrisdicaprio et al

ref https://github.com/GNS-Science/solvis/blob/17932977c78ea0298eb755633fe4d979211952e3/solvis/inversion_solution/fault_system_solution.py#L153

With new SLTs the solvis library need to treat old and new model versions differently. This stems from our decision to support multiple sources in a given LTB (previously there was just one).

But:

  1. we do not use this feature in current NSHM_v1.* models and,
  2. solvis LIB, API and UI will all need rework to support multiple inversion_solutions within one LT branch.

So, this ticket proposes that we constrain the nzshm-model library to support the old API version, so:

  • recreate the old branch property solution_id (it can use the code linked above)
  • either a) validate any new logic trees to ensure only a single inversion is added OR,
  • b) allow multiple inversion solutions but make it clear to users that these cannot be used for solvis solution aggregation OR
  • c) support both a & b, but signal to users which applies for a given Source LT / model.

NB It might be possible to modify solvis somewhat to handle these two cases elegantly. @chrisdicaprio can we come up with real-world an example of B) to use as a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LIB for filtering nzshm-model for filtering
Projects
None yet
Development

No branches or pull requests

1 participant