Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor large source files? #169

Open
michaelchin opened this issue Apr 3, 2024 · 4 comments
Open

refactor large source files? #169

michaelchin opened this issue Apr 3, 2024 · 4 comments
Assignees
Labels
low on ice put the issue on ice for now suggestion ideas to discuss

Comments

@michaelchin
Copy link
Contributor

Some of the source files are growing too large(thousands of lines). Maybe consider to divide them into small files and add sub-folder when necessary.
consider, discuss and decide

@michaelchin michaelchin added the suggestion ideas to discuss label Apr 4, 2024
@michaelchin michaelchin self-assigned this May 12, 2024
@cpalfonso
Copy link
Collaborator

I came up with some improvements to the subduction teeth functions a while ago (such as specifying tooth size/spacing in points rather than projected units, as well as recalculating and redrawing the teeth when the extent of the plot changes) which involved some fairly extensive changes to the gplately.plot module, so I could have a look at breaking up that file when I implement those changes.

@cpalfonso cpalfonso self-assigned this May 31, 2024
@michaelchin
Copy link
Contributor Author

I came up with some improvements to the subduction teeth functions a while ago (such as specifying tooth size/spacing in points rather than projected units, as well as recalculating and redrawing the teeth when the extent of the plot changes) which involved some fairly extensive changes to the gplately.plot module, so I could have a look at breaking up that file when I implement those changes.

Thanks, but no need to worry about it. I will take care of that.

@michaelchin
Copy link
Contributor Author

I came up with some improvements to the subduction teeth functions a while ago (such as specifying tooth size/spacing in points rather than projected units, as well as recalculating and redrawing the teeth when the extent of the plot changes) which involved some fairly extensive changes to the gplately.plot module, so I could have a look at breaking up that file when I implement those changes.

Hi @cpalfonso

just out of curiosity, are you coming back to work on gplately? What's the plan?

@brmather

@michaelchin michaelchin added the on ice put the issue on ice for now label Jun 17, 2024
@michaelchin
Copy link
Contributor Author

New pygplates will be released soon. The new GPlately release will follow soon. It is not a good time to refactor or touch working code. Put this issue on ice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low on ice put the issue on ice for now suggestion ideas to discuss
Projects
None yet
Development

No branches or pull requests

2 participants