Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Evaluators #112

Closed
36 of 42 tasks
r-bartlett-gsa opened this issue Aug 7, 2024 · 2 comments · Fixed by #243
Closed
36 of 42 tasks

Delete Evaluators #112

r-bartlett-gsa opened this issue Aug 7, 2024 · 2 comments · Fixed by #243
Assignees

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Aug 7, 2024

User story

As a challenge manager, in order to maintain an accurate list of available evaluators, I would like to be able to delete an evaluator from my list.

Acceptance criteria:

  • A challenge manager can delete evaluators that they entered for their challenge
    • Deleted evaluators are removed from the evaluator list for that challenge and they are not available for submissions assignment of that challenge
    • If an evaluator that is being deleted is already assigned to a submission, a message is displayed for a challenge manager indicating so and asking to confirm deletion
      • Deleted evaluator is removed from assignment to submissions
      • Evaluation data saved or submitted by a deleted evaluator is not displayed and is not used for average score calculation

Dev tasks:

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
  • Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
  • Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
  • Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Usability testing: mobile and desktop (Tracy or Marni)
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata / Tracy / Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Aug 8, 2024

Some button styles, colors and labels may have changed and screenshots below may reflect outdated styles. Please refer to Figma for latest designs.
Misalignment in styles, colors and labels should not affect the completion of development work. There will be additional user stories towards the end of this epic or MVP to bring uniformity to styles and colors.
If significant difference is noticed in features / functionality, please contact Renata.

Image

@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Nov 22, 2024

Note: the submissions assignment when an evaluator is deleted will need to be tested a later time when #75 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants