[394] Update Submissions Stats Dashboards #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 tasks
stepchud
reviewed
Feb 24, 2025
Comment on lines
+26
to
+28
| 'green-cool-vivid-60v': #216E1F, | ||
| 'orange-warm-vivid-50v': #CF4900, | ||
| 'red-vivid-60v': #B50909 |
stepchud
reviewed
Feb 24, 2025
| @@ -17,6 +17,9 @@ def index | |||
| @unassigned_submissions = @evaluator_assignments. | |||
| where(status: %i[unassigned recused_unassigned]). | |||
| ordered_by_status | |||
| @recused_submissions = @evaluator_assignments. | |||
| where(status: %i[recused]). | |||
| ordered_by_status | |||
There was a problem hiding this comment.
do these need to be ordered_by_status?
There was a problem hiding this comment.
Nope, you're right - recused submissions don't need to be ordered by status 😅
stepchud
reviewed
Feb 24, 2025
| <div class="display-flex flex-row tablet:margin-left-auto tablet:margin-top-0 margin-top-3"> | ||
| <div class="text-center bg-green-cool-vivid-60v padding-1 margin-right-1" style="width: 32%"> | ||
| <span class="font-sans-xl text-white text-bold display-block"><%= @submissions_count["completed"] || 0 %></span> | ||
| <span class="font-sans-3xs tablet:font-sans-sm text-white">COMPLETED<br>EVALUATIONS</span> |
There was a problem hiding this comment.
capitalization can be handled by css property text-transform, which is text-uppercase in USWDS
There was a problem hiding this comment.
e.g.
Suggested change
| <span class="font-sans-3xs tablet:font-sans-sm text-white">COMPLETED<br>EVALUATIONS</span> | |
| <span class="font-sans-3xs tablet:font-sans-sm text-white text-uppercase">Completed<br>Evaluations</span> |
stepchud
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked ticket: #394
Update submission stats dashboards:
Add colors required in the updated figma.
Evaluator Submissions list
Challenge Managers Submission list
Evaluator Management Submissions list page
WAVE