Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert data.json contains critical datasets #329

Open
adborden opened this issue Jul 16, 2019 · 3 comments
Open

Assert data.json contains critical datasets #329

adborden opened this issue Jul 16, 2019 · 3 comments
Assignees

Comments

@adborden
Copy link

There's been a few occasions where some critical datasets have been removed from the data.json, which causes them to be removed from data.gov. This brings a lot of attention and inbound questions to the GSA data owner on why the datasets were deleted, when in reality, it was unintended. We should add a special test that ensures these datasets are present in the data.json and run this as part of CI.

cc @CinnyaSm

@adborden
Copy link
Author

I'm not a Ruby person but a simple check could look like this:

datasets = load_dataset_titles_from_data_json(data_json_filepath)
for title in expected_dataset_titles:
  assert title in datasets

@CinnyaSm
Copy link
Contributor

Jeff,

Below is a list of the FRPP datasets that I need to ensure don't disappear from data.gov.
• FY 2016 Federal Real Property Profile Data for Civilian Agencies
• FY 2016 Federal Real Property Profile Data for Department of Defense
• FY 2017 Federal Real Property Profile Data for Civilian Agencies
• FY 2017 Federal Real Property Profile Data for Department of Defense
• FY 2018 Federal Real Property Profile Data for Civilian Agencies

Please let me know if you need any additional information.

@jfredrickson5
Copy link

Ensure critical datasets are always present on open.gsa.gov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants