From c9b7bcb52d4f5f8be1a01f9e1abc9dd3401b47a5 Mon Sep 17 00:00:00 2001 From: trinsdar <30245301+Trinsdar@users.noreply.github.com> Date: Sun, 23 Feb 2025 09:27:51 -0500 Subject: [PATCH] made PipeFluidHandlerSidedWrapper use IFluidHandler methods --- .../antimatter/capability/FluidHandler.java | 1 + .../fluid/PipeFluidHandlerSidedWrapper.java | 25 ++++++++++--------- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/common/src/main/java/muramasa/antimatter/capability/FluidHandler.java b/common/src/main/java/muramasa/antimatter/capability/FluidHandler.java index c8aa4b24a..c00b9b9c7 100644 --- a/common/src/main/java/muramasa/antimatter/capability/FluidHandler.java +++ b/common/src/main/java/muramasa/antimatter/capability/FluidHandler.java @@ -161,6 +161,7 @@ public FluidStack drain(FluidStack fluid, FluidAction action) { return FluidStack.EMPTY; } + @NotNull @Override public FluidStack drain(int toExtract, FluidAction action) { if (getOutputTanks() != null){ diff --git a/common/src/main/java/muramasa/antimatter/capability/fluid/PipeFluidHandlerSidedWrapper.java b/common/src/main/java/muramasa/antimatter/capability/fluid/PipeFluidHandlerSidedWrapper.java index f66f962b4..bd5056361 100644 --- a/common/src/main/java/muramasa/antimatter/capability/fluid/PipeFluidHandlerSidedWrapper.java +++ b/common/src/main/java/muramasa/antimatter/capability/fluid/PipeFluidHandlerSidedWrapper.java @@ -6,6 +6,8 @@ import muramasa.antimatter.blockentity.pipe.BlockEntityFluidPipe; import muramasa.antimatter.capability.FluidHandler; import net.minecraft.core.Direction; +import net.minecraftforge.fluids.FluidStack; +import net.minecraftforge.fluids.capability.IFluidHandler; import org.jetbrains.annotations.NotNull; public class PipeFluidHandlerSidedWrapper extends FluidHandlerSidedWrapper{ @@ -18,14 +20,14 @@ public PipeFluidHandlerSidedWrapper(FluidHandler fluidHandler, BlockEntityFlu } @Override - public long insertFluid(FluidHolder resource, boolean simulate) { + public int fill(FluidStack resource, FluidAction action) { if (side == null) return 0; if (coverHandler != null) { - if (coverHandler.get(side).blocksInput(FluidContainer.class, side)) { + if (coverHandler.get(side).blocksInput(IFluidHandler.class, side)) { return 0; } - long oldAmount = resource.getFluidAmount(); - if(coverHandler.onTransfer(resource, side, true, simulate)) return oldAmount - resource.getFluidAmount(); + int oldAmount = resource.getAmount(); + if(coverHandler.onTransfer(resource, side, true, action.simulate())) return oldAmount - resource.getAmount(); } if (!fluidHandler.canInput(resource, side) || !fluidHandler.canInput(side)) { @@ -33,20 +35,19 @@ public long insertFluid(FluidHolder resource, boolean simulate) { } int tank = fluidHandler.getInputTanks().getFirstAvailableTank(resource, false); if (tank == -1) return 0; - long insert = fluidHandler.getInputTanks().getTank(tank).insertFluid(resource, simulate); - if (insert > 0 && !simulate){ + int insert = fluidHandler.getInputTanks().getTank(tank).fill(resource, action); + if (insert > 0 && action.execute()){ pipe.setLastSide(side, tank); } return insert; } - @NotNull @Override - public FluidHolder extractFluid(FluidHolder resource, boolean simulate) { - if (side == null) return FluidHooks.emptyFluid(); - if (coverHandler != null && (coverHandler.get(side).blocksOutput(FluidContainer.class, side) || coverHandler.onTransfer(resource, side, false, simulate))) { - return FluidHooks.emptyFluid(); + public @NotNull FluidStack drain(FluidStack resource, FluidAction action) { + if (side == null) return FluidStack.EMPTY; + if (coverHandler != null && (coverHandler.get(side).blocksOutput(IFluidHandler.class, side) || coverHandler.onTransfer(resource, side, false, action.simulate()))) { + return FluidStack.EMPTY; } - return super.extractFluid(resource, simulate); + return super.drain(resource, action); } }