Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] CardModal.jsx file is too big #156

Open
nmhossain02 opened this issue Apr 5, 2023 · 0 comments
Open

[Refactor] CardModal.jsx file is too big #156

nmhossain02 opened this issue Apr 5, 2023 · 0 comments

Comments

@nmhossain02
Copy link
Contributor

CardModal.jsx is 562 lines long at the moment, making it hard to navigate. Here are some suggested refactorings that would make the code look prettier:

  • Extract component that renders when editing is true/false to new files
  • Use theme variants for button stylings
  • Extract image carousel components to new file (maybe)
  • Extract onClick handlers outside of render method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant